[FE-6183] Update Permissions on Credentials Files #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptpaterson
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
Credentials are clearly most important. Do we want to limit access for the shell history file as well? Genuine question -- I don't feel strongly that we do, but want to ask what others think.
No problem just merging this though.
I think we should (err on the side of security). Users may be passing confidential info as args to UDFs and such. |
echo-bravo-yahoo
approved these changes
Dec 6, 2024
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket(s): FE-6183
Problem
Credential files are readable by non-owners.
Solution
Set them to
chmod 600when the file is created.Result
Credential files are not readable by non-owners.
Testing