default oauth to prod client #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwilde345
commented
Dec 5, 2024
cleve-fauna
reviewed
Dec 5, 2024
cleve-fauna
approved these changes
Dec 5, 2024
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
CLI was defaulting to the oauth client that frontdoor uses when it's hosted locally.
This means nobody should need to set any env vars when logging in to the shell, unless they wanna go to dev/prev
Solution
Customers should default to prod. Remember this client secret isn't really secret and that's ok in this OAuth contract strategy.
Also dumping Fauna-prefixed env vars in the
logArgvmiddleware for FE-6173Out of Scope
Option to redact specific env vars or argv attributes. Helpful for customers that want to copy pasta verbose output straight into a bug report.