Don't let config parse for help or version when getting profile #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecooper
requested review from
echo-bravo-yahoo,
mwilde345,
cleve-fauna and
henryfauna
echo-bravo-yahoo
force-pushed
the
v3-let-help-help
branch
from
217c9a3 to
78b1253
Compare
henryfauna
approved these changes
Dec 5, 2024
echo-bravo-yahoo
approved these changes
Dec 5, 2024
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We parse args in the config middleware, but do not disable help or version. This means they will always execute before our actual help.
Solution
Turn off help.
Result
Help from the command show.