Create Key #468
Merged
Create Key #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echo-bravo-yahoo
force-pushed
the
v3_basicCreateKey
branch
from
37aef98 to
c010034
Compare
cleve-fauna
force-pushed
the
v3_basicCreateKey
branch
from
c010034 to
05c286e
Compare
cleve-fauna
force-pushed
the
v3_basicCreateKey
branch
from
d1c7ecb to
b10cc1e
Compare
cleve-fauna
commented
Dec 5, 2024
echo-bravo-yahoo
approved these changes
Dec 5, 2024
henryfauna
approved these changes
Dec 5, 2024
| `Invalid ttl '${argv.ttl}'. Provide as an ISO 8601 date time string.`, | ||
| ); | ||
| } | ||
| if (argv.database === undefined && argv.secret === undefined) { |
There was a problem hiding this comment.
I think we have a validation helper that does this already. I think it's called validateDatabaseOrSecret
There was a problem hiding this comment.
had to add this bc of tweaks i made in this command big dog.
There was a problem hiding this comment.
if you odon't have this it asks you to login, which is insufficient.
cleve-fauna
force-pushed
the
v3_basicCreateKey
branch
from
d84e9db to
9a47c6f
Compare
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket(s): FE-6128
Problem
Creating a key is needed for the CLI. It is also needed to establish a --local pattern that works for many commands.
Solution
In this PR do a basic create key implementation that uses the account API.
Result
We got it started.
Testing
Ran the full suite.