lint and prettify on PR push/change #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echo-bravo-yahoo
force-pushed
the
pretty-lint
branch
6 times, most recently
from
69721ce to
93b2501
Compare
echo-bravo-yahoo
force-pushed
the
pretty-lint
branch
2 times, most recently
from
ea48a47 to
231a742
Compare
echo-bravo-yahoo
commented
Dec 4, 2024
Comment on lines
-27
to
-31
| env: | ||
| TERM: xterm-256color | ||
| # Set to the correct color level; 2 is 256 colors | ||
| # https://github.com/chalk/chalk?tab=readme-ov-file#supportscolor | ||
| FORCE_COLOR: 2 |
There was a problem hiding this comment.
this was copied from the tests (where it's relevant for the test runner), but isn't needed here, so i'm removing it. this job has color support & the linter detects it:
echo-bravo-yahoo
commented
Dec 4, 2024
| @@ -73,11 +73,13 @@ | |||
| "test": "npm run test:local", | |||
| "test:local": "mocha --recursive ./test --require ./test/mocha-root-hooks.mjs --reporter mocha-multi-reporters --reporter-options configFile=./test/config/reporter.json", | |||
| "pretest:ci": "npm run build:app", | |||
| "test:ci": "mocha --recursive ./test --require ./test/mocha-root-hooks.mjs --reporter mocha-multi-reporters --reporter-options configFile=./test/config/reporter.json", | |||
| "test:ci": "mocha --forbid-only --recursive ./test --require ./test/mocha-root-hooks.mjs --reporter mocha-multi-reporters --reporter-options configFile=./test/config/reporter.json", | |||
There was a problem hiding this comment.
CI test runs now fail if they encounter any usages of .only(...). Local test runs allow .only(...) for easier debugging.
echo-bravo-yahoo
force-pushed
the
pretty-lint
branch
from
034e0a5 to
076053c
Compare
ecooper
approved these changes
Dec 4, 2024
henryfauna
approved these changes
Dec 5, 2024
echo-bravo-yahoo
force-pushed
the
pretty-lint
branch
from
076053c to
c997e42
Compare
this change updates the linting github action to commit the changes that prettier causes. this will keep the codebase consistently prettified without requiring client-side git hooks. it could also commit linting changes (by running `npm run lint --fix`), but this PR does not enable that out of an abundance of caution for the changes the linter might introduce.
echo-bravo-yahoo
force-pushed
the
pretty-lint
branch
from
c997e42 to
d85965e
Compare
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this change updates the linting github action to fail if prettier or eslint suggest any changes.
to make this manageable, this change also adds a husky hook that runs on commit and re-formats and lints (without committing the resulting changes). this should help keep the codebase consistently prettified.