Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FE-6169] Support Shorthand Region Groups #464

Merged
merged 6 commits into from
Dec 4, 2024
Merged

Conversation

henryfauna
Copy link
Contributor

@henryfauna henryfauna commented Dec 4, 2024

Ticket(s): FE-6169

Problem

You must use the region groups that the account api expects as input to the --database arg. eg. --database us-std/my-database. We do not often expose the name us-std to customers and it will likely be more natural to use --database us/my-database as that is what is presented in the dashboard.

Solution

Standardize region groups before they are passed to the account API. This allows the usage of --database us-std/my-database or --database us/my-database.

Result

You can use whatever region group reference you prefer.

Testing

Updated existing tests.

@henryfauna henryfauna changed the base branch from main to v3 December 4, 2024 20:30
@henryfauna henryfauna requested a review from a team as a code owner December 4, 2024 20:30
@henryfauna henryfauna force-pushed the support-abbrv-regions branch from 37df9da to 54b1a18 Compare December 4, 2024 21:07
@henryfauna henryfauna requested review from echo-bravo-yahoo and a team December 4, 2024 21:11
@ecooper ecooper self-requested a review December 4, 2024 22:52
@ecooper ecooper merged commit f165610 into v3 Dec 4, 2024
4 checks passed
@ecooper ecooper deleted the support-abbrv-regions branch December 4, 2024 23:09
@cleve-fauna cleve-fauna mentioned this pull request Dec 5, 2024
This was referenced Dec 6, 2024
@cleve-fauna cleve-fauna mentioned this pull request Dec 13, 2024
@wildemat wildemat mentioned this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants