group options #463
Merged
group options #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echo-bravo-yahoo
force-pushed
the
group-options
branch
from
ae9fc8d to
94d6250
Compare
ptpaterson
reviewed
Dec 4, 2024
There was a problem hiding this comment.
What do you think about something like "Authentication/Authorization" instead of "API"? definitely more verbose... "AuthN/Z"? "Auth"?
There was a problem hiding this comment.
here's what's in the group now:
i feel like database and url are only tenuously auth? but it is a clearer expression of what they do than "API". except for those 2? bleh.
ptpaterson
approved these changes
Dec 4, 2024
right now, we present all the options in one blob. this change groups the config options into these groups: - Output (format, quiet, color) - Config (config, profile) - API (user, role, database, secret) - Debug (verbosity, verboseComponent) - Options (help and all command-specific options) these groups can/should be renamed and rearranged, but this grouping should be a readability improvement over the current soup of flags.
echo-bravo-yahoo
force-pushed
the
group-options
branch
from
94d6250 to
c5c1cb6
Compare
henryfauna
approved these changes
Dec 4, 2024
jrodewig
reviewed
Dec 4, 2024
| }, | ||
| verboseComponent: { | ||
| description: | ||
| "Components to emit diagnostic logs for. Takes precedence over the `--verbosity` flag. Pass components as a comma-separate list, such as `--verboseComponent fetch, error`, or as separate flags, such as `--verboseComponent fetch --verboseComponent error`.", | ||
| "Components to emit diagnostic logs for. Takes precedence over the `--verbosity` flag. Pass components as a space-separated list, such as `--verboseComponent fetch error`, or as separate flags, such as `--verboseComponent fetch --verboseComponent error`.", |
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
right now, we present all the options in one blob. this change groups the config options into these groups:
these groups can/should be renamed and rearranged, but this grouping should be a readability improvement over the current soup of flags.
before:
after:
