Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable strict options parsing #460

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Conversation

echo-bravo-yahoo
Copy link
Contributor

env variables for query settings (FAUNA_SECRET, etc) are too useful to not
have set, but they fail strict options parsing for commands that don't
use them. this commit turns off strict options parsing for now while we find a
better way to address this.

@echo-bravo-yahoo echo-bravo-yahoo requested a review from a team as a code owner December 4, 2024 18:19
@echo-bravo-yahoo echo-bravo-yahoo force-pushed the disable-strict-options branch 5 times, most recently from c1f5562 to cd32d6b Compare December 4, 2024 22:09
echo-bravo-yahoo and others added 2 commits December 4, 2024 15:35
env variables for query settings (FAUNA_SECRET, etc) are too useful to not
have set, but they fail strict options parsing for commands that don't
use them. this commit turns off strict options parsing for now while we find a
better way to address this.
Copy link
Contributor

@ptpaterson ptpaterson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good to me

@echo-bravo-yahoo echo-bravo-yahoo merged commit 3b48bad into v3 Dec 4, 2024
4 checks passed
@echo-bravo-yahoo echo-bravo-yahoo deleted the disable-strict-options branch December 4, 2024 23:36
@cleve-fauna cleve-fauna mentioned this pull request Dec 5, 2024
This was referenced Dec 6, 2024
@cleve-fauna cleve-fauna mentioned this pull request Dec 13, 2024
@wildemat wildemat mentioned this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants