Add colorized output to database, query, and shell commands #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 3, 2024 16:00
ecooper
requested review from
echo-bravo-yahoo,
wildemat,
cleve-fauna and
henryfauna
cleve-fauna
reviewed
Dec 4, 2024
Comment on lines
+20
to
+21
| // We use stderr for messaging and there's no stdout output for a deleted database | ||
| logger.stderr(`Database '${argv.name}' was successfully deleted.`); |
There was a problem hiding this comment.
Send messaging to stderr. Log messages, errors, and so on should all be sent to stderr. This means that when commands are piped together, these messages are displayed to the user and not fed into the next command.
This won't be a command that is piped, but the spirit remains.
cleve-fauna
approved these changes
Dec 4, 2024
henryfauna
approved these changes
Dec 4, 2024
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The database, query, and shell commands all output JSON. It's pretty printed, but does not support color. It's hard to scan as a result
Solution
For the database, query, and shell commands support colorized json output by default. This is done through the
formatObjectForShellandformatFullErrorForShellhelpers. The rest of this PR is largely just plumbing the color option through and updating tests.Result
Query w/ color:
Color w/out color:
A different, fauna-like theme can be added in a follow-up PR.
Testing
Tests were updated to handle color changes.