[FE-6155] - Support --database in database commands
#454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wildemat
reviewed
Dec 4, 2024
echo-bravo-yahoo
approved these changes
Dec 4, 2024
wildemat
approved these changes
Dec 4, 2024
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket(s): FE-6155
Problem
The
database createanddatabase deletecommands do not support specifying a target database using--database.Solution
Update the commands to support this flag by using the
getSecrethelper. Ensure bad creds are only retried/refreshed if we are not using a user provided secret. Some validation was also included to check that at least one of these flags is provided.Result
The
--databaseflag is supported bydatabase createanddatabase delete.Testing
Added tests to cover the usage of
--database.