FE-6024 Implement shell history #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptpaterson
force-pushed
the
fe-6024-repl-history-2
branch
from
a5d6277 to
3f12c25
Compare
wildemat
reviewed
Dec 3, 2024
ptpaterson
force-pushed
the
fe-6024-repl-history-2
branch
from
711882f to
94863ae
Compare
wildemat
approved these changes
Dec 3, 2024
cleve-fauna
reviewed
Dec 4, 2024
cleve-fauna
reviewed
Dec 4, 2024
ptpaterson
force-pushed
the
fe-6024-repl-history-2
branch
from
002a0d5 to
8dec6c9
Compare
echo-bravo-yahoo
approved these changes
Dec 4, 2024
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket(s): FE-6024
Problem
We use the built-in Node.js REPL for the
shellcommand, but don't leverage the native history feature.Solution
Setup and register
~/.fauna/historyfile and tell the REPL to use it for history.Add a shell
.clearhistoryshell command to clear the history.Move file utils to use the containerized
fsmodule.ignore
test/test-homedirResult
Screen.Recording.2024-11-22.at.4.45.00.PM.mov
Testing
Updated test container to not stub
node:fsby default. This required some existing tests to stub it out, but allowed others that need native fs behavior.Added tests for shell history. Each test specifies a different homedir, so that they tests won't collide with each other.