FE-5990 Set argv.secret to 'secret' when --local passed in and --secret is not. Always respect argv.secret when getting a secret with FaunaClient.getSecret. #449
+57
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et is not. Always respect argv.secret when getting a secret with FaunaClient.getSecret.
ptpaterson
approved these changes
Dec 3, 2024
cleve-fauna
commented
Dec 3, 2024
wildemat
reviewed
Dec 3, 2024
wildemat
approved these changes
Dec 3, 2024
ecooper
reviewed
Dec 3, 2024
Comment on lines
+107
to
+118
| .middleware((argv) => { | ||
| if (!argv.url) { | ||
| if (argv.local) { | ||
| argv.url = 'http://localhost:8443'; | ||
| } else { | ||
| argv.url = 'https://db.fauna.com'; | ||
| } | ||
| } | ||
| if (!argv.secret && argv.local) { | ||
| argv.secret = "secret"; | ||
| } | ||
| }) |
There was a problem hiding this comment.
If you move this into a function, we can unit test it as an individual middleware.
There was a problem hiding this comment.
will do. i love my end to end tests tho.
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket(s): FE-5990
Problem
--localmust set up user to user a local container. This means:http://localhost:8443if no explicit--urlis provided.secretif no explicit--secretis provided.(1) is already shipped.
This PR implements (2).
Additionally, I noticed that we were not respecting
argv.secretin query or shell. This PR fixes that.Solution
I updated the coercion based on local's present to set
argv.secretif no explicit secret is given.Result
Users can easy use a default Fauna container; and can tweak it with a custom secret or URL
Out of Scope
--localis passed.loginTesting