-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support running commands against container. #447
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9346ed3
to
4cb2faa
Compare
4cb2faa
to
3cbc32c
Compare
wildemat
approved these changes
Dec 3, 2024
ptpaterson
reviewed
Dec 3, 2024
ptpaterson
reviewed
Dec 3, 2024
ptpaterson
approved these changes
Dec 3, 2024
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket(s): FE-5990
Problem
Customers need to easily run CLI commands against a Fauna container. This is useful when they run tests, configure developer environments, etc.
Solution
Long term we'll do this by:
url
based on presence of local flag. URL is set to localhost:8443 if nourl
is passed in.Start work to support this by:
url
based on presence of local flag. URL is set to localhost:8443 if nourl
is passed in.I made this happen by replacing the usage of the object spread syntax with a function call when setting up common arguments. i.e.
is now
This allows us to do the URL adapting.
I will do this over several PRs. This PR is very bare bones; it does the above and nothing else. Over the next few PRs I will also add:
Result
The big change here is that I added a new way to inject the "common options". We need to do this by calling a function now instead of using the object spread syntax when building yargs.
Testing
Added tests to confirm URL setting works as expected.
Ran the existing tests. My goal with this PR is to ship this new means of yargs construction so this work does not drift from v3.