Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix config tests #442

Merged
merged 2 commits into from
Nov 26, 2024
Merged

fix config tests #442

merged 2 commits into from
Nov 26, 2024

Conversation

echo-bravo-yahoo
Copy link
Contributor

@echo-bravo-yahoo echo-bravo-yahoo commented Nov 26, 2024

No description provided.

@echo-bravo-yahoo echo-bravo-yahoo changed the title maybe fix tests on other people's systems fix config tests Nov 26, 2024
these vary for local environments for some people. since the config
tests aren't intended to test colors (and they don't do anything special
with colors), there's no reason to test them that way.
@echo-bravo-yahoo echo-bravo-yahoo marked this pull request as ready for review November 26, 2024 19:22
@echo-bravo-yahoo echo-bravo-yahoo requested a review from a team as a code owner November 26, 2024 19:22
Copy link
Contributor

@ptpaterson ptpaterson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wildemat wildemat merged commit 33271d3 into v3 Nov 26, 2024
4 checks passed
@wildemat wildemat deleted the config-without-colors branch November 26, 2024 19:44
@cleve-fauna cleve-fauna mentioned this pull request Dec 5, 2024
This was referenced Dec 6, 2024
@cleve-fauna cleve-fauna mentioned this pull request Dec 13, 2024
@wildemat wildemat mentioned this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants