Fauna Query Options #441
Merged
Fauna Query Options #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptpaterson
reviewed
Nov 26, 2024
Comment on lines
+12
to
+24
| if (argv.secret && argv.database) { | ||
| // Providing a database and secret are conflicting options. If both are provided, | ||
| // it is not clear which one to use. | ||
| throw new Error( | ||
| "Cannot use both the '--secret' and '--database' options together. Please specify only one.", | ||
| ); | ||
| } else if (argv.role && argv.secret) { | ||
| // The '--role' option is not supported when using a secret. Secrets have an | ||
| // implicit role. | ||
| logger.warn( | ||
| "The '--role' option is not supported when using a secret. It will be ignored.", | ||
| ); | ||
| } |
There was a problem hiding this comment.
Could probably factor these checks out into command-helpers and then use that to check everywhere commonQueryOptions are used. If you agree, as a follow up sounds fine to me.
There was a problem hiding this comment.
yup definitely - I'll factor stuff out when I get to updating keys
ptpaterson
approved these changes
Nov 26, 2024
Comment on lines
-49
to
-54
| // export async function ensureDbScopeClient({ scope, version, argv }) { | ||
| // const path = scope.split("/"); | ||
|
|
||
| // const { connectionOptions } = await getClient({ version: "4", argv }); | ||
| // const { hostname, port, protocol } = new URL(connectionOptions.url); | ||
|
|
echo-bravo-yahoo
approved these changes
Nov 26, 2024
Co-authored-by: echo-bravo-yahoo <[email protected]>
This was referenced Dec 2, 2024
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We will always want to enable a certain set of options for commands that talk to fauna. These options include
url,secret,databaseandrole. At the moment these are spread around, some defined at the top level of the cli and other kept in thecommonQueryOptionsobject.Solution
Consolidate these options in one place and setup some validation on top of them so users are warned if they specify conflicting or redundant args.
Result
It will be easier to wire up just in time db keys for commands that talk to fauna.
Out of Scope
Doing the same things with the
keycommands.Testing
Added new tests to make sure the arg validation works.