improve type inference on things pulled from awilix #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the types for the container were broken; this commit fixes them. as a result, typescript server can properly infer the type of things resolved off the awilix container. unfortunately, it's likely not going to work in all situations - for instance, i've noticed that JSDoc comments are dropped.
Comment on lines
-6
to
-16
| import keyCommand from "./commands/key.mjs"; | ||
| import databaseCommand from "./commands/database/database.mjs"; | ||
| import evalCommand from "./commands/eval.mjs"; | ||
| import shellCommand from "./commands/shell.mjs"; | ||
| import keyCommand from "./commands/key.mjs"; | ||
| import loginCommand from "./commands/login.mjs"; | ||
| import schemaCommand from "./commands/schema/schema.mjs"; | ||
| import databaseCommand from "./commands/database/database.mjs"; | ||
|
|
||
| import shellCommand from "./commands/shell.mjs"; | ||
| import { authNZMiddleware } from "./lib/auth/authNZ.mjs"; | ||
| import { checkForUpdates, fixPaths, logArgv } from "./lib/middleware.mjs"; | ||
|
|
||
| /** @typedef {import('awilix').AwilixContainer<import('./config/setup-container.mjs').modifiedInjectables>} cliContainer */ |
There was a problem hiding this comment.
ran linter which reordered the dependencies
cleve-fauna
approved these changes
Nov 23, 2024
wildemat
approved these changes
Nov 23, 2024
This was referenced Dec 2, 2024
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the types for the container were broken; this commit fixes them. as a result, typescript server can properly infer the type of things resolved off the awilix container. unfortunately, it's likely not going to work in all situations - for instance, i've noticed that JSDoc comments are dropped.
before, looking at something registered with asValue:
before, looking at something registered with asClass:
after, looking at something registered with asValue:
after, looking at something registered with asClass:
