-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config #422
Merged
Merged
Config #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
827ebae
to
9cb3030
Compare
henryfauna
approved these changes
Nov 25, 2024
63fe4a5
to
8315bbd
Compare
8315bbd
to
6f74587
Compare
wildemat
approved these changes
Nov 26, 2024
jrodewig
reviewed
Nov 26, 2024
@@ -255,6 +255,7 @@ function buildEvalCommand(yargs) { | |||
query: { | |||
type: "string", | |||
description: "the query to run", | |||
required: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this right? I thought a user could specify --query
or --file
, and they're mutually exclusive.
This was referenced Dec 2, 2024
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brief
this change implements the
--config
flag, adds config parsing to the CLI, and adds env var parsing to the CLI.it will accept any flags that any commands or subcommands define, but attempts to use a command with an incompatible flag will fail because of strict mode. because of this, it's wisest to only use globally defined flags for the default profile.
how does config actually work?
given a config file with this content (note that JSON is also valid):
and this env var:
running
fauna eval --query "Database.all()"
would:fauna eval --secret "not-so-secret" --color --query "Database.all()"