persist secrets #393
Merged
persist secrets #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+118
to
+122
| // Whether authNZ middleware should run. Better way of doing this? | ||
| authRequired: { | ||
| hidden: true, | ||
| default: false, | ||
| }, |
There was a problem hiding this comment.
what's the intent here / why would you change it?
ah, does this indicate which commands "need" auth?
Comment on lines
+30
to
+31
| console.log("got account key", accountKey); | ||
| console.log("got db secret", dbSecret); |
There was a problem hiding this comment.
use verbosity-based logging (logger.debug etc)
Comment on lines
+29
to
+31
| if (e instanceof InvalidCredsError) { | ||
| promptLogin(profile); | ||
| } else { |
There was a problem hiding this comment.
should skip prompt (and fail) if argv.noInput is set
There was a problem hiding this comment.
ah, i see that prompt just bails. this is ok with noInput set or unset.
| secret: dbKey, | ||
| endpoint: url, | ||
| }); | ||
| const result = await client.query("0"); |
There was a problem hiding this comment.
is there any advantage to pre-checking instead of trying to do the work? is it that we can do it still in the middleware before reaching the handler?
echo-bravo-yahoo
approved these changes
Oct 21, 2024
Merged
Closed
This was referenced Dec 2, 2024
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket(s): FE-###
Problem
Explain the context and why you're making that change. What is the problem you're trying to solve? In some cases there is not a problem and this can be thought of being the motivation for your change.
Solution
Describe the modifications you've done.
Result
What will change as a result of your pull request? Note that sometimes this section is unnecessary because it is self-explanatory based on the solution.
Testing
Describe the manual and automated tests you completed to verify the change is working as expected.