disable code signing for windows

fauna · Oct 25, 2024 · f48edcf · f48edcf
1 parent a4006c1
commit f48edcf
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/sea/build-sea.cjs b/sea/build-sea.cjs
@@ -43,12 +43,14 @@ function buildSEAForMac() {
 function buildSEAForWindows() {
   run("node --experimental-sea-config .\\sea\\sea-config.json");
   fs.copyFileSync(process.execPath, ".\\dist\\fauna.exe");
-  const signtool = "C:\\\"Program Files (x86)\"\\\"Microsoft SDKs\"\\ClickOnce\\SignTool\\signtool.exe";
-  run(`${signtool} remove /s /c /u .\\dist\\fauna.exe`);
+  // more details on signing:
+  // https://learn.microsoft.com/en-us/dotnet/framework/wcf/feature-details/how-to-create-temporary-certificates-for-use-during-development#installing-a-certificate-in-the-trusted-root-certification-authorities-store
+  // const signtool = "C:\\\"Program Files (x86)\"\\\"Microsoft SDKs\"\\ClickOnce\\SignTool\\signtool.exe";
+  // run(`${signtool} remove /s /c /u .\\dist\\fauna.exe`);
   run(
     "npx postject .\\dist\\fauna.exe NODE_SEA_BLOB .\\dist\\sea.blob ^ \
     --sentinel-fuse NODE_SEA_FUSE_fce680ab2cc467b6e072b8b5df1996b2"
   );
-  run(`${signtool} sign /fd SHA256 .\\dist\\fauna.exe`);
+  // run(`${signtool} sign /fd SHA256 .\\dist\\fauna.exe`);
   run("chmod +x ./dist/fauna");
 }