Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v10 driver - empty 200 response throws protocol error #313

Merged
merged 3 commits into from
Dec 17, 2024
Merged

Conversation

wildemat
Copy link
Contributor

@wildemat wildemat commented Dec 13, 2024

Description

https://faunadb.atlassian.net/browse/FE-6237

Core router may return a 200 with an empty response, indicating an issue on their end. See LSE
Don't try to parse that like we do a normal response, instead throw a protocol error.

How was the change tested?

Added a query test

Screenshots (if appropriate):

Shell before:
Screenshot 2024-12-16 at 6 06 46 PM

Shell after:
Screenshot 2024-12-16 at 12 10 48 PM

Change types

    • Bug fix (non-breaking change that fixes an issue)

@wildemat wildemat requested a review from ptpaterson December 13, 2024 18:21
@wildemat wildemat requested a review from cleve-fauna December 13, 2024 19:04
@wildemat wildemat changed the title throw internal error on 200 with no content v10 driver - empty 200 response throws protocol error Dec 16, 2024
@wildemat wildemat requested a review from a team December 16, 2024 23:08
@wildemat wildemat merged commit d004758 into main Dec 17, 2024
7 checks passed
@wildemat wildemat deleted the fe-6237 branch December 17, 2024 17:49
@wildemat wildemat mentioned this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants