-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial error handling #36
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good start, and the direction is right. I added a few specific comments, but generally what I'd like to see is more specificity on each type. Ideally minimize the number of nullable properties so users can confidently interact with error objects without reading documentation about what might be null. In addition, make sure they are elevated to the top level.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more things to sort out I think
Added initial backoff retry impementation
This PR contains initial error handling in the Fauna client: