Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use generated serializers for QueryVal serialization #145

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

pnwpedro
Copy link
Contributor

Description

  • Use DynamicSerializer as default for type serializers
  • Generate a type serializer for QueryVal.Serialize()
  • Implement Serialize for all StructSerializers

Motivation and context

  • We can now implement Serialize for each type serializer with smaller PRs
  • Prepares for the addition of a registry where users can call Serializer.Registry.Add(type, serializer) to be used in the serialize/deserialize paths.

How was the change tested?

  • Existing tests pass

Screenshots (if appropriate):

Change types

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (backwards-incompatible fix or feature)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to Fauna documentation.
  • My change requires a change to the README, and I have updated it accordingly.

@pnwpedro pnwpedro force-pushed the use-typed-serializers branch from 9402d4e to b668851 Compare July 24, 2024 11:41
@pnwpedro pnwpedro force-pushed the use-typed-serializers branch from b668851 to a7127c1 Compare July 24, 2024 11:42
@pnwpedro pnwpedro merged commit 80ec519 into main Jul 29, 2024
4 checks passed
@pnwpedro pnwpedro deleted the use-typed-serializers branch July 29, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants