Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ExceptionsFactory #139

Merged
merged 5 commits into from
Jul 16, 2024
Merged

Update ExceptionsFactory #139

merged 5 commits into from
Jul 16, 2024

Conversation

cynicaljoy
Copy link
Contributor

@cynicaljoy cynicaljoy commented Jul 16, 2024

BT-4967

Problem

Need to validate exception types align with the known response types from Fauna

Solution

  • Update ExceptionFactory
  • Include test suite for validation

@cynicaljoy cynicaljoy requested a review from pnwpedro July 16, 2024 14:23
Copy link
Contributor

@pnwpedro pnwpedro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@cynicaljoy cynicaljoy changed the title Update ExceptionsFactor with tests Update ExceptionsFactory Jul 16, 2024
@cynicaljoy cynicaljoy merged commit e88cc09 into main Jul 16, 2024
4 checks passed
@cynicaljoy cynicaljoy deleted the error-type-tests branch July 16, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants