Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roundtrip short and ushort serialization #127

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Conversation

pnwpedro
Copy link
Contributor

@pnwpedro pnwpedro commented Jul 1, 2024

Problem

Deserialization is motivated by the Fauna token it interacts with, not the target type. This is reasonable for a default case where we don't know what type we want, but when we know, we should use the right deserializer.

Solution

Continue down the path of using dedicated deserializers for known types.

Base automatically changed from remove-type-overrides to main July 1, 2024 16:25
@pnwpedro pnwpedro merged commit 392f061 into main Jul 1, 2024
4 checks passed
@pnwpedro pnwpedro deleted the roundtrippable-shorts branch July 1, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants