Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation warning for Rio sample data #213

Merged
merged 2 commits into from
Dec 9, 2019
Merged

Conversation

leouieda
Copy link
Member

Licensing for the dataset is unclear it's best to remove it. We'll
deprecate first and then remove in a future major release. Add warnings
to the docstrings and sample data example. Replace the Rio data with
Texas wind in the Trend gallery example (it's already used in the trend
estimation tutorial). See #201 for more context.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst and verde/__init__.py.
  • Write detailed docstrings for all functions/classes/methods.
  • If adding new functionality, add an example to the docstring, gallery, and/or tutorials.

Licensing for the dataset is unclear it's best to remove it. We'll
deprecate first and then remove in a future major release. Add warnings
to the docstrings and sample data example. Replace the Rio data with
Texas wind in the Trend gallery example (it's already used in the trend
estimation tutorial). See #201 for more context.
Copy link
Member

@santisoler santisoler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good! 🥇

@leouieda leouieda merged commit f020804 into master Dec 9, 2019
@leouieda leouieda deleted the rio-deprecation branch December 9, 2019 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants