fix(backoff): close of closed out channel #3871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wuqinqiang
changed the title
fatedier
reviewed
Dec 21, 2023
fatedier
approved these changes
Dec 21, 2023
github-actions bot
added a commit
to aiastia-dockerhub/frp
that referenced
this pull request
Jan 3, 2024
* https://github.com/fatedier/frp: cmd: use hyphen instead of underscore (fatedier#3898) upgrade go-jose and crypto version (fatedier#3895) fix(client): close workConn when authentication err (fatedier#3885) improve e2e port allocator (fatedier#3882) let e2e concurrency configurable (fatedier#3881) fix login retry interval (fatedier#3879) fix lint (fatedier#3877) fix: duplicate call loginFunc (fatedier#3860) (fatedier#3875) fix(backoff): close of closed out channel (fatedier#3871) remove copilot for pr (fatedier#3857) update doc (fatedier#3844) feat: ssh doc (fatedier#3841)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY
currently, MergeAndCloseOnAnyStopChannel may repeatedly call close out chan multiple times. even if Try0 recovered the panic. we should make sure that only once