feat(ads): activate AdSense on suburb detail page - #172
Merged
Merged
Conversation
chore: enable repo automation (CodeRabbit + release-please)
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…--components--suburblens chore(main): release suburblens 1.1.0
feat: add about page
feat: Add a reusable site footer and mount it across the main pages
feat: AdSense readiness — content hardening, verification & privacy disclosure
Stage the AdSense ad-unit code ahead of approval so placement is a one-liner once real data-ad-slot IDs exist (adsense-plan §3.5). Not wired into any page yet. AdSlot renders one <ins> (client ca-pub-5982385876517812) in a Nocturne card with an Advertisement label. A pushed ref keeps adsbygoogle.push() idempotent under StrictMode; callers pass a route-changing key to remount. index.css collapses unfilled/blocked slots so they leave no gap.
feat + refactor: Promote dev to main: suburb discovery + query/error/a11y cleanup
…--components--suburblens chore(main): release suburblens 1.2.0
Wire the previously dormant AdSlot into SuburbDetailPage now that the AdSense account is approved and a real Display ad unit (slot 8314950736) exists. One non-intrusive slot at the end of the stacked card list, keyed to urlSalCode so it refreshes when navigating between suburbs. Auto ads left off.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughThe change adds a responsive AdSense slot to suburb detail pages. It prevents duplicate ad pushes, hides unfilled slots, updates the release version to 1.2.0, and adds changelog entries for releases 1.2.0 and 1.1.0. ChangesAdSense release
Estimated code review effort: 2 (Simple) | ~10 minutes Sequence Diagram(s)sequenceDiagram
participant SuburbDetailPage
participant AdSlot
participant AdSenseQueue
participant AdSenseLayout
SuburbDetailPage->>AdSlot: render slot 8314950736
AdSlot->>AdSenseQueue: push one ad request
AdSenseQueue->>AdSenseLayout: populate or mark slot unfilled
AdSenseLayout->>AdSlot: apply ad status
Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Merges the AdSense integration into dev. The two ad-related changes:
feat: add dormant AdSlot component and unfilled-slot CSS— the dormantAdSlot.tsxplus the unfilled-slot collapse CSS.feat(ads): place first adsense unit on suburb detail page— now that the account is approved, wireAdSlotintoSuburbDetailPage(slot8314950736), placed at the end of the card list before the Footer,key={urlSalCode}so it refreshes when navigating between suburbs. Auto ads left off.The branch also carries the merge/release commits picked up while syncing with main, so merging this brings dev up to the latest release.
Why
The AdSense account is approved ("Getting ready", ads.txt Authorized) and a first Display ad unit was created, so the pre-staged but dormant ad slot can finally go live and start earning impressions.
How to test
cd frontend && npx tsc --noEmit— type-checks clean.npm run dev, open any suburb detail page and scroll to the bottom: an "Advertisement" slot appears above the Footer. (Locally / pre-serving it may rendee empty slot collapses so there's no deadspace.)key={urlSalCode}).Summary by CodeRabbit
New Features
Documentation
Release