New Features about Number.prototype.toLocaleString() for IE11 in win7 and 8, a lot of related new definitions
#52
Conversation
|
can I remove all |
src/lib/features.js
Outdated
| { | ||
| var available = | ||
| checkLocaleNumeral('ar', NaN, /^ليس برقم/) && | ||
| checkLocaleNumeral('ar', Infinity, /^+لا.نهاية/) && |
There was a problem hiding this comment.
I'm getting a syntax error on this regular expression.
If the tests pass I'd say yes. |
src/lib/features.js
Outdated
| checkLocaleNumeral('ar', NaN, /^ليس.برقم/) && | ||
| checkLocaleNumeral('ar', Infinity, /^\+لا.نهاية/) && | ||
| checkLocaleNumeral('ar-td', 234567890.1, /^٢٣٤٬?٥٦٧٬?٨٩٠٫١/) && | ||
| checkLocaleNumeral('cz', NaN, /^Není.číslo/) && |
There was a problem hiding this comment.
I'm trying this in IE 11 on Windows 7, but NaN.toLocaleString('cz') results in 'NaN'.
src/lib/features.js
Outdated
| checkLocaleNumeral('lt', Infinity, /^begalybė/) && | ||
| checkLocaleNumeral('lv', Infinity, /^bezgalība/) && | ||
| checkLocaleNumeral('pl', Infinity, /^\+nieskończoność/) && | ||
| checkLocaleNumeral('ru', Infinity, /^бесконечность/) && |
There was a problem hiding this comment.
Infinity.toLocaleString('lv') and Infinity.toLocaleString('ru') are giving "∞" on Windows 8.
Co-authored-by: Francesco Trotta <[email protected]>
Clayblockunova
changed the title
LOCALE_NUMERALS_IE11_WIN7, a lot of related new definitionsNumber.prototype.toLocaleString() for IE11 in win7 and 8, a lot of related new definitions
|
what should I do now? |
| var LOCALE_NUMERALS_IE11_WIN7 = Feature.LOCALE_NUMERALS_IE11_WIN7; | ||
| var LOCALE_NUMERALS_IE11_WIN7_8 = Feature.LOCALE_NUMERALS_IE11_WIN7_8; | ||
| var LOCALE_NUMERALS_IE11_WIN8 = Feature.LOCALE_NUMERALS_IE11_WIN8; |
There was a problem hiding this comment.
I'm not sure if this division makes sense. It seems that these features depend on the version of certain DLLs used by IE, and these DLLs could be updated independently from the operating system, for example with Windows updates. This is especially true for Windows 7 and 8 where IE was integrated with other system components.
There was a problem hiding this comment.
so, what should I do? should I just remove Latvian and Russian related definition?
There was a problem hiding this comment.
I don't know yet. I will have to do some more analysis.
There was a problem hiding this comment.
is your analysis finished now?
There was a problem hiding this comment.
and, what should I do to Latvian and Russian related definition?
|
Sorry for closing this PR since I have something else to add. |
I think
useLocaleNumeralDefinition()should also be updated to ensure all paddings included.