Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secret store cleanup #1112

Closed
wants to merge 13 commits into from
Closed

Secret store cleanup #1112

wants to merge 13 commits into from

Conversation

vcarvajal-sigsci
Copy link
Collaborator

@vcarvajal-sigsci vcarvajal-sigsci commented Feb 12, 2025

@guybedford
Copy link
Member

I'm not sure this is where the issue is - these skips are just because we are running two test suites side by side, so we only need to do setup once, and teardown once either side of those runs.

Rather I think the issue is within the teardown script itself that it is not disposing the secret store properly, which needs to be tested against the Fastly API.

@vcarvajal-sigsci
Copy link
Collaborator Author

vcarvajal-sigsci commented Feb 12, 2025

I'm not sure this is where the issue is - these skips are just because we are running two test suites side by side, so we only need to do setup once, and teardown once either side of those runs.

Rather I think the issue is within the teardown script itself that it is not disposing the secret store properly, which needs to be tested against the Fastly API.

The original error I was encountering was that we were exceeding our number of stores because we kept creating them
Output [Error]: ERROR: the Fastly API returned 400 Bad Request: Bad Request (limit exceeded: number of stores).
But now after creating the secret store, we're trying to retrieve the store id, we are getting a 404 stating the record isn't found.
Creating new config store aZ2 __ 2__app_secret_store_cleanup__debug ERROR: the Fastly API returned 404 Not Found: Record not found.
Also, the skips are no longer acceptable arguments in test.js, I don't see being used
But good point about further testing against the Fastly API, I'll continue on that path.

dependabot bot and others added 6 commits February 13, 2025 12:27
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…rver-cli (#1107)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…-cli (#1116)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…er-cli (#1117)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@vcarvajal-sigsci vcarvajal-sigsci deleted the secret-store-cleanup branch February 13, 2025 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants