Adds getting a list of domains for service_id #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethvargo
suggested changes
Oct 15, 2018
fastly/service.go
Outdated
| } | ||
|
|
||
| // ListDomain lists all domains associated with a given service | ||
| func (c *Client) ListDomain(i *ListServiceDomainInput) (ServiceDomainsList, error) { |
There was a problem hiding this comment.
I think this should be plural (ListDomains). What do you think?
There was a problem hiding this comment.
I agree - it should be pluralized. However there is already a method name in the library called ListDomains (it's located in the domain.go and it calls /domains/list).
I say we rename it to ListServiceDomains.
sethvargo
approved these changes
Oct 16, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an additional method to call the
/service/SERVICE_ID/domainendpoint to retrieve a list of domains for a given Service ID. Corresponding endpoint and documentation here: https://docs.fastly.com/api/config#service_d5578a1e3bc75512711ddd0a58ce7a36