Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interface for stats and realtime analytics #48

Merged
merged 2 commits into from
Jul 27, 2017

Conversation

msuterski
Copy link
Contributor

This adds an interface to the historical and realtime stats endpoints.

The tests do not verify any data because it would be different for any service or account. Just verify that the http requests are successful.

@sethvargo
Copy link
Contributor

This looks really good - one question. Do you think realtimestats should be its own client? It feels a bit weird that these methods would be available on a regular client too. Or is that intended?

@msuterski
Copy link
Contributor Author

The realtime stats are published from a different endpoint (api.fasty.com vs rt.fastly.com). I'm not sure how we could use the same client to talk to different hostnames? Is there a way?

I actually had it implemented as a separate type to be explicit which methods are available through which client type, but though it was a bit of an overkill. I can put it back.

@sethvargo
Copy link
Contributor

Hey @msuterski

Yea - I know the RTS are different endpoints, which is why I think it makes sense for them to be different API clients.

@msuterski
Copy link
Contributor Author

Ok, I'll push an update to this. Thanks!

Add missing fields to response object for realtime stats
@msuterski msuterski changed the title Add intercase for stats and realtime analytics Add interface for stats and realtime analytics Jul 27, 2017
@msuterski
Copy link
Contributor Author

Updated to use a separate client type for the RTS API calls.

Let me know if it works for you, please.

@sethvargo sethvargo merged commit 2266008 into fastly:master Jul 27, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Aug 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants