feat(auth): OAuth/PCKE callers #470
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phamann
requested changes
Nov 9, 2023
| @@ -54,6 +55,7 @@ func (c *Client) RawRequest(verb, p string, ro *RequestOptions) (*http.Request, | |||
| // Set the API key. | |||
| if len(c.apiKey) > 0 { | |||
| request.Header.Set(APIKeyHeader, c.apiKey) | |||
| request.Header.Set("Authorization", fmt.Sprintf("Bearer %s", c.apiKey)) | |||
There was a problem hiding this comment.
Should this be c.apiKey? That would set the value of the bearer to the API token and not the desired OAuth JWT access_token,
|
@phamann I've pinged you internally to explain my thought process. I'm going to close this PR as I think it's premature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a future world, callers (such as the Fastly CLI) will authenticate using OAuth (specifically the PKCE extension flow) and so the token that is provided will need to be used with the
AuthenticationHTTP request header.