Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: bump minimum go version to 1.19 #467

Merged
merged 2 commits into from
Aug 31, 2023
Merged

build: bump minimum go version to 1.19 #467

merged 2 commits into from
Aug 31, 2023

Conversation

Integralist
Copy link
Collaborator

@Integralist Integralist commented Aug 30, 2023 •
edited

The latest go version is 1.21 and I like to keep go-fastly two versions back from the latest.

NOTE: This shouldn't be considered a breaking change because Go docs suggest a user's project (which might be, for example, using Go 1.18) should still compile with this version of go-fastly because Go is backwards compatible and we've not used any features that are new to 1.19

@Integralist Integralist added the dependencies Pull requests that update a dependency file label Aug 30, 2023
dkegel-fastly
dkegel-fastly approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@dkegel-fastly dkegel-fastly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM tho I wonder whether the staticcheck you're using needs updating...

@Integralist Integralist merged commit e1e8522 into main Aug 31, 2023
2 checks passed
@Integralist Integralist deleted the integralist/bump-go-version branch August 31, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkegel-fastly dkegel-fastly dkegel-fastly approved these changes

@joeshaw joeshaw Awaiting requested review from joeshaw

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Integralist @dkegel-fastly