Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Config Store support #398

Merged
merged 2 commits into from
Mar 9, 2023
Merged

feat: Add Config Store support #398

merged 2 commits into from
Mar 9, 2023

Conversation

awilliams-fastly
Copy link
Collaborator

@awilliams-fastly awilliams-fastly commented Feb 16, 2023 •
edited
Loading

awilliams-fastly added a commit to fastly/cli that referenced this pull request Feb 16, 2023
@awilliams-fastly
feat(config-store): Add Config Store commands
87875ea 
Related `go-fastly` change: fastly/go-fastly#398
@awilliams-fastly awilliams-fastly mentioned this pull request Feb 16, 2023
Merged
awilliams-fastly added a commit to fastly/cli that referenced this pull request Feb 23, 2023
@awilliams-fastly
feat(config-store): Add Config Store commands
ad37409 
Related `go-fastly` change: fastly/go-fastly#398
@awilliams-fastly awilliams-fastly marked this pull request as ready for review March 2, 2023 19:11
awilliams-fastly added a commit to fastly/cli that referenced this pull request Mar 2, 2023
@awilliams-fastly
feat(config-store): Add Config Store commands
157fa85 
- https://developer.fastly.com/reference/api/services/resources/config-store/
- https://developer.fastly.com/reference/api/services/resources/config-store-item/

Related `go-fastly` change: fastly/go-fastly#398
Integralist
Integralist reviewed Mar 6, 2023
View reviewed changes
Copy link
Collaborator

@Integralist Integralist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a couple of comment.

fastly/config_store.go Outdated Show resolved Hide resolved
fastly/config_store_item.go Show resolved Hide resolved
fastly/config_store_item_test.go Show resolved Hide resolved
@awilliams-fastly
Remove input validation
e6d490a 
The convention is for the API to validate arguments, unless it's
required for URL path generation.
@awilliams-fastly awilliams-fastly merged commit 0c20056 into main Mar 9, 2023
@awilliams-fastly awilliams-fastly deleted the awilliams/config-store branch March 9, 2023 17:26
awilliams-fastly added a commit to fastly/cli that referenced this pull request Mar 14, 2023
@awilliams-fastly
feat(config-store): Add Config Store commands
ec57261 
- https://developer.fastly.com/reference/api/services/resources/config-store/
- https://developer.fastly.com/reference/api/services/resources/config-store-item/

Related `go-fastly` change: fastly/go-fastly#398
@Integralist Integralist added the enhancement New feature or request label Mar 15, 2023
awilliams-fastly added a commit to fastly/cli that referenced this pull request Mar 15, 2023
@awilliams-fastly
feat(config-store): Add Config Store commands
f429d79 
- https://developer.fastly.com/reference/api/services/resources/config-store/
- https://developer.fastly.com/reference/api/services/resources/config-store-item/

Related `go-fastly` change: fastly/go-fastly#398

```
USAGE
  fastly config-store <command> [<args> ...]

COMMANDS
  config-store
  create         Create a new config store
  delete         Delete a config store
  describe       Retrieve a single config store
  list           List config stores
  list-services  List config store's services
  update         Update a config store
```

```
USAGE
  fastly config-store-entry <command> [<args> ...]

COMMANDS
  config-store-entry
  create    Create a new config store item
  delete    Delete a config store item
  describe  Retrieve a single config store item
  list      List config store items
  update    Update a config store item
```
awilliams-fastly added a commit to fastly/cli that referenced this pull request Mar 16, 2023
@awilliams-fastly
feat(config-store): Add Config Store commands (#829)
183f127 
- https://developer.fastly.com/reference/api/services/resources/config-store/
- https://developer.fastly.com/reference/api/services/resources/config-store-item/

Related `go-fastly` change: fastly/go-fastly#398

```
USAGE
  fastly config-store <command> [<args> ...]

COMMANDS
  config-store
  create         Create a new config store
  delete         Delete a config store
  describe       Retrieve a single config store
  list           List config stores
  list-services  List config store's services
  update         Update a config store
```

```
USAGE
  fastly config-store-entry <command> [<args> ...]

COMMANDS
  config-store-entry
  create    Create a new config store item
  delete    Delete a config store item
  describe  Retrieve a single config store item
  list      List config store items
  update    Update a config store item
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Integralist Integralist Integralist approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@awilliams-fastly @Integralist