Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for modsec_rule_id filter parameter #322

Merged
merged 3 commits into from
Jan 5, 2022
Merged

Add support for modsec_rule_id filter parameter #322

merged 3 commits into from
Jan 5, 2022

Conversation

smaeda-ks
Copy link
Contributor

@smaeda-ks smaeda-ks mentioned this pull request Jan 4, 2022
Merged
@smaeda-ks
Copy link
Contributor Author

@Integralist

Integralist
Integralist approved these changes Jan 5, 2022
View reviewed changes
Copy link
Collaborator

@Integralist Integralist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can we regenerate the fixtures to help validate the changes.

fastly/waf_rules.go Show resolved Hide resolved
@smaeda-ks
Copy link
Contributor Author

@Integralist Thanks. Added a test for this change.

@Integralist Integralist merged commit 46a99c6 into fastly:main Jan 5, 2022
@Integralist Integralist added the enhancement New feature or request label Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Integralist Integralist Integralist approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@smaeda-ks @Integralist