Add HTTP 206 Partial Content to stats #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is returned by the realtime API, and should be included in the stats struct so it can be used.
Integralist
approved these changes
Jun 8, 2021
|
When can I expect this to be in a release? |
|
Hi @noseglid This would come under a new minor release but I'd ideally have more stuff included in a new release than this one line change 🙂 I have a bunch of work upcoming for go-fastly, and so I'll likely group this change into that release. That said, is there an urgency to this being released? Is there a bug you're currently experiencing which currently is tricky to workaround without this change? If so then that might change my perspective on whether the new release should consist this single addition and how quickly. Thanks. |
|
Nah... I’m missing this stat in my reporting which makes the reports look
kinda odd but nothing too substantial.
I was merely probing for an approximate time but not rushed
…On Wed, 9 Jun 2021 at 10:26, Mark McDonnell ***@***.***> wrote:
Hi @noseglid <https://github.com/noseglid>
This would come under a new minor release but I'd ideally have more stuff
included in a new release than this one line change 🙂
I have a bunch of work upcoming for go-fastly, and so I'll likely group
this change into that release.
That said, is there an urgency to this being released? Is there a bug
you're currently experiencing which currently is tricky to workaround
without this change? If so then that might change my perspective on whether
the new release should consist this single addition and how quickly.
Thanks.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#277 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHD76EBMW2GAMAWGD5ORZLTR4QTDANCNFSM46HSFVEA>
.
|
|
👋🏻 @noseglid squeezed a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is returned by the realtime API, and should be included in the stats struct so it can be used.