Create new error abstraction for field validation #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integralist
force-pushed
the
integralist/2020_11_19_missed_refs
branch
2 times, most recently
from
f93a1be
to
7a28525
Compare
Integralist
commented
Dec 21, 2020
Integralist
force-pushed
the
integralist/2020_11_19_missed_refs
branch
2 times, most recently
from
16eb5b9
to
7b8e719
Compare
Integralist
commented
Jan 4, 2021
Integralist
commented
Jan 4, 2021
phamann
requested changes
Jan 4, 2021
Integralist
force-pushed
the
integralist/2020_11_19_missed_refs
branch
4 times, most recently
from
6e2d33e
to
d0140e5
Compare
|
@phamann changes made, waiting re-review |
phamann
approved these changes
Jan 6, 2021
|
@phamann yes. the author replied to me eariler to say they would take a look next week. So with that in mind. I can merge this change but not cut a release until after they've managed to wrap up any other changes and write some tests in their PR. |
Integralist
force-pushed
the
integralist/2020_11_19_missed_refs
branch
from
d0140e5
to
33c924a
Compare
Integralist
changed the title
Integralist
force-pushed
the
integralist/2020_11_19_missed_refs
branch
from
cfabd53
to
72e149f
Compare
Integralist
force-pushed
the
integralist/2020_11_19_missed_refs
branch
from
e1c3545
to
dc644df
Compare
|
@fastly/developer-relations @phamann I've reverted a bunch of approved changes (see the latest commits above). I'm going to open a few separate PRs to home these changes (as they've already been approved by Patrick they should be quick to review/approve) but it'll help ensure the dynamically generated CHANGELOG will have explicit callouts to each change (whereas if I kept them all within this PR they would be lost). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create new error abstraction for field validation. This helps with consistency and maintainability.