Add support for Kinesis logging endpoint #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integralist
requested changes
Nov 20, 2020
There was a problem hiding this comment.
Thanks @kellymclaughlin for this PR!
I've just some small comments and requested changes.
Updates to make kinesis logging use v2 conventions and some minor changes based on review feedback.
|
👋🏻 @kellymclaughlin I've been on paternity leave so I'm going to try and get round to re-reviewing this today. |
Integralist
reviewed
Dec 9, 2020
Integralist
reviewed
Dec 9, 2020
Integralist
approved these changes
Dec 11, 2020
Integralist
approved these changes
Dec 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.