-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for users #145
Conversation
or maybe @phamann ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this contribution @sbfaulkner.
👍 LGTM other than a minor nit about struct fields.
if this is good, I'd appreciate if y'all could merge and ship a new version of the package (so we can add some terraform support for it) |
Apologies, @sbfaulkner I forgot to CC @philippschulte in my PR review, I'd like to get his approval before we merge and cut a new release. @philippschulte This looks good to me, can you please review and release? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, thank you! I just commented on a couple of details.
maybe now @philippschulte |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Thanks for the changes!
this PR adds support (and tests) for user-related API operations
the endpoints supported are...
GET /users
GET /customer/<id>/users
GET /current_user
GET /user/<id>
POST /user
PUT /user/<id>
DELETE /user/<id>
/cc @philippschulte