add support for users #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
or maybe @phamann ? |
phamann
approved these changes
Feb 20, 2020
There was a problem hiding this comment.
Thanks for this contribution @sbfaulkner.
👍 LGTM other than a minor nit about struct fields.
|
if this is good, I'd appreciate if y'all could merge and ship a new version of the package (so we can add some terraform support for it) |
|
Apologies, @sbfaulkner I forgot to CC @philippschulte in my PR review, I'd like to get his approval before we merge and cut a new release. @philippschulte This looks good to me, can you please review and release? |
philippschulte
requested changes
Feb 24, 2020
|
maybe now @philippschulte |
philippschulte
approved these changes
Feb 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR adds support (and tests) for user-related API operations
the endpoints supported are...
GET /users
GET /customer/<id>/users
GET /current_user
GET /user/<id>
POST /user
PUT /user/<id>
DELETE /user/<id>
/cc @philippschulte