Add methods for Token CRUD API endpoints #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phamann
force-pushed
the
phamann/get-token-self
branch
2 times, most recently
from
b1b4317
to
cf06cec
Compare
| r.AddFilter(func(i *cassette.Interaction) error { | ||
| delete(i.Request.Headers, "Fastly-Key") | ||
| return nil | ||
| }) |
There was a problem hiding this comment.
👏 Why didn't we implement this earlier 😭
philippschulte
approved these changes
Sep 25, 2019
phamann
force-pushed
the
phamann/get-token-self
branch
from
cf06cec
to
8ae551d
Compare
|
@philippschulte thanks for the review, let me know if you want me to merge this and cut a release or if you want to? |
|
@phamann thanks for fixing the build by updating the dependencies. I am happy to take care of the release! However, there is one more step you'll need to do in order to wrap this PR up. Please run Thanks in advance. |
phamann
force-pushed
the
phamann/get-token-self
branch
from
8ae551d
to
1435f6e
Compare
|
@philippschulte Apologies for the delay, I have now tidied the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Adds methods to expose API Token management (list, get, create, delete) endpoints: https://docs.fastly.com/api/auth#tokens.
Notes:
AddFiltermethod on the recorder instance to automatically strip API keys from requests.