-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add methods for Token CRUD API endpoints #131
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
b1b4317
to
cf06cec
Compare
r.AddFilter(func(i *cassette.Interaction) error { | ||
delete(i.Request.Headers, "Fastly-Key") | ||
return nil | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 Why didn't we implement this earlier 😭
cf06cec
to
8ae551d
Compare
@philippschulte thanks for the review, let me know if you want me to merge this and cut a release or if you want to? |
@phamann thanks for fixing the build by updating the dependencies. I am happy to take care of the release! However, there is one more step you'll need to do in order to wrap this PR up. Please run
Thanks in advance. |
8ae551d
to
1435f6e
Compare
@philippschulte Apologies for the delay, I have now tidied the |
TL;DR
Adds methods to expose API Token management (list, get, create, delete) endpoints: https://docs.fastly.com/api/auth#tokens.
Notes:
AddFilter
method on the recorder instance to automatically strip API keys from requests.