Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Go Modules #130

Merged
merged 1 commit into from
Aug 5, 2019
Merged

Switch to Go Modules #130

merged 1 commit into from
Aug 5, 2019

Conversation

philippschulte
Copy link
Member

@philippschulte philippschulte commented Jul 25, 2019

I guess it's about time to migrate to Go modules! Don't freak out that a couple of files have been deleted! It's actually very nice how Go modules filter out unnecessary files. The ones deleted are mostly test and benchmarking files and other stuff which are not necessary for building the package.

Copy link
Member

@phamann phamann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for doing this work @philippschulte 🎉

Copy link
Contributor

@trentrosenbaum trentrosenbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ok to me :)

@philippschulte philippschulte merged commit 5c6c8bd into fastly:master Aug 5, 2019
@philippschulte philippschulte deleted the switch-to-go-modules branch August 5, 2019 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants