Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for override_host field #120

Merged
merged 1 commit into from
Jun 14, 2019
Merged

Add support for override_host field #120

merged 1 commit into from
Jun 14, 2019

Conversation

philippschulte
Copy link
Member

@philippschulte philippschulte commented Jun 7, 2019 •
edited

🎉This closes #119.

phamann
phamann approved these changes Jun 11, 2019
View reviewed changes
Copy link
Member

@phamann phamann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

matpimenta
matpimenta previously requested changes Jun 11, 2019
View reviewed changes
Copy link
Contributor

@matpimenta matpimenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, could you just add the change to the changelog?

@philippschulte
feat(backend): add support for override_host field
8238718 
The override_host field can be used to override the Host header.

fix #119
@philippschulte philippschulte dismissed matpimenta’s stale review June 14, 2019 00:14

I'll update the CHANGELOG before I cut a new release.

@philippschulte philippschulte merged commit 8b7e2c9 into fastly:master Jun 14, 2019
@philippschulte philippschulte deleted the add-support-for-override_host-field branch June 14, 2019 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phamann phamann phamann approved these changes

@matpimenta matpimenta matpimenta left review comments

@trentrosenbaum trentrosenbaum Awaiting requested review from trentrosenbaum

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for override_host in field
3 participants
@philippschulte @phamann @matpimenta