Add support for version comment in request payload #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethvargo
approved these changes
Mar 29, 2019
| headers: | ||
| Accept-Ranges: | ||
| - bytes | ||
| - bytes | ||
| - bytes |
There was a problem hiding this comment.
This is probably a bug in the VCR recorder, but this is leaking. No action required on your part, more of a mental note for me.
There was a problem hiding this comment.
This seems like a bug. I have checked my latest PRs and they all have the same issue with Accept-Ranges in the recordings.
| @@ -84,10 +84,11 @@ func (c *Client) LatestVersion(i *LatestVersionInput) (*Version, error) { | |||
| type CreateVersionInput struct { | |||
| // Service is the ID of the service (required). | |||
| Service string | |||
|
|
|||
| Comment string `form:"comment,omitempty"` | |||
There was a problem hiding this comment.
Please comment this (irony recognized) using Go's comment string so it's rendered in the client library docs on godoc.org.
There was a problem hiding this comment.
That makes sense. I'll also add a comment to the Comment field of the UpdateVersionInput struct.
Add comment field to CreateVersionInput struct and attach payload to CreateVersion request. fix #102
sethvargo
approved these changes
Apr 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves #102.