Revert handle_fanout_ws behavior to correctly echo the request body #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkarneges
approved these changes
Dec 11, 2024
|
The main difference in this fix is that we are first starting by cloning the incoming request's body directly into the response's body. This is the correct behavior, because the request body may contain more than one encoded WebSocket message in a batch, and to be an echo server all of these messages need to be echoed directly back to the response. Additionally, OPEN is guaranteed to be the first one in a batch, so checking the first few bytes for it works. If it is found, then the handler adds the subscribe message and WebSocket extension header to the response. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1, some of the test endpoints were refactored to make them easier to understand.
At that time, it seems that the handle_fanout_ws() function's behavior was changed in a way that lost some of its original echo behavior. This PR reverts that behavior and adds a few comments.