Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework to forward by default, and update readme #19

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

jkarneges
Copy link
Member

This reworks the kit to forward through Fanout by default (rather than forwarding without Fanout by default), and explicitly marks the app-handled endpoints as test endpoints (/stream/ -> /test/). Also, the readme has been corrected in a few places (notably the API call example was using the pre-api.fastly.com style).

The goal of this change is to:

  1. Unify the two Fanout starter kits. This one kit will be suitable for either forwarding or as a starting point for edge apps, and the fanout-forward kit can be deprecated.
  2. Enable using Fanout without having to understand Compute. The kit does not require modification for production use. Users can set and forget.

The test endpoints only work for domains ending in .edgecompute.app. This is similar to the original Fanout.io behavior, where test endpoints are not enabled on custom domains.

@jkarneges jkarneges requested a review from a team as a code owner June 6, 2024 19:30
@jkarneges jkarneges requested review from doramatadora and removed request for a team June 6, 2024 19:30
Copy link
Member

@harmony7 harmony7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!

@jkarneges jkarneges merged commit 51ae690 into main Jun 7, 2024
1 check passed
@jkarneges jkarneges deleted the jkarneges/unified-kit branch June 7, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants