-
Notifications
You must be signed in to change notification settings - Fork 9
Use FastlyMeta for RequestID and SandboxID #212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dgryski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Merge conflict to be resolved. |
|
|
||
| func main() { | ||
| var requests int | ||
| var requestCount int |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add request count to FastlyMeta? It's something I would really like to have in my usage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have to fix conflicts. Seems like a safe add?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opened #215 as a PR onto this branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just rebased this. You should be able to merge on top once this goes green again.
705faad to
5124f51
Compare
This makes accessing the
RequestIDandSandboxIDfromfsthttp.Requestconsistent, and enables a move away from reading theFASTLY_TRACE_IDenvironment variable forSandboxIDwhich is confusing now that we haveRequestID.Users are encouraged to use
RequestID()to uniquely identify individual requests being served.Fixes #183
The
RequestIDvalue comes from this host call: