This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
👻 add empty workspace members array #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This odd little commit is a workaround for a Cargo workspaces bug, described in rust-lang/cargo#6745; this workaround is described in a comment there[1]. When using this repository as a submodule, it becomes impossible to validate the definitions with the command below, if it contains a Cargo workspace: ``` cargo run --manifest-path=validate-witx/Cargo.toml ./compute-at-edge.witx ``` Moreover, we cannot always add the repo to the `exclude` array, for reasons explained in the attached Cargo issue. So, we'll introduce this empty workspace array, to avoid that issue for now. [1]: rust-lang/cargo#6745 (comment)
mgattozzi
approved these changes
Jul 7, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This odd little commit is a workaround for a Cargo workspaces bug,
described in rust-lang/cargo#6745; this workaround is described in a
comment there1.
When using this repository as a submodule, it becomes impossible to
validate the definitions with the command below, if it contains a Cargo
workspace:
Moreover, we cannot always add the repo to the
excludearray, forreasons explained in the attached Cargo issue.
So, we'll introduce this empty workspace array, to avoid that issue for
now.