Add closing functionality to Viceroy for Handles #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cratelyn
suggested changes
Aug 23, 2021
lib/src/session.rs
Outdated
| @@ -252,6 +252,23 @@ impl Session { | |||
| .ok_or(HandleError::InvalidBodyHandle(handle)) | |||
| } | |||
|
|
|||
| /// Drop a [`Body`][body] from the [`Session`], given its [`BodyHandle`][handle]. | |||
There was a problem hiding this comment.
i think we can use intradoc links here 🙂
There was a problem hiding this comment.
Oh right I had just copied from what we had before let me fix that up
cratelyn
reviewed
Aug 23, 2021
lib/src/session.rs
Outdated
Comment on lines
262
to
263
| // Unlike take_body we don't want to call into_body | ||
| // as this will cause an InvalidBodyHandle error |
There was a problem hiding this comment.
sorry, i have one more nitpick.
could you reword this comment slightly? i was confused for a moment why this would cause an invalid handle error; upon further reading i've realized that you meant this function would return said error because BodyVariant::into_body will return None in the streaming case
|
No worries @cratelyn should be good now |
mgattozzi
force-pushed
the
mgattozzi/closing-the-handles
branch
from
54ce4d5 to
2ceca65
Compare
This adds the ability for Viceroy to handle closing handles for Response, Request, Body, and StreamingBody Handle types via the close host calls that were added to the public ABI and internally for C@E which has rolled out to the fleet. While this does not include any SDK updates for the tests, I've tested this out with the new version of the Rust SDK to make sure things work out correctly which helped find a bug or with how I implemented it with Viceroy. With this we can still work with old versions of the SDK and handle the new SDK as well. Closes #64
|
I did a full squash so I can merge with just the one commit @cratelyn and so will need a ♻️ ✔️ |
cratelyn
approved these changes
Aug 23, 2021
|
❤️ Thanks @cratelyn |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability for Viceroy to handle closing handles for
Response, Request, Body, and StreamingBody Handle types via the close
host calls that were added to the public ABI and internally for C@E
which has rolled out to the fleet. While this does not include any SDK
updates for the tests, I've tested this out with the new version of the
Rust SDK to make sure things work out correctly which helped find a bug
or with how I implemented it with Viceroy. With this we can still work
with old versions of the SDK and handle the new SDK as well.
Closes #64