Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌦 Allow partial CA store to be loaded #104

Merged
merged 2 commits into from
Dec 14, 2021
Merged

🌦 Allow partial CA store to be loaded #104

merged 2 commits into from
Dec 14, 2021

Conversation

aturon
Copy link
Contributor

@aturon aturon commented Dec 13, 2021

This change more closely mimics the setup we previously had with hyper_rustls, and allows Viceroy to be used even if only some root certificates could be loaded.

I believe this change will address #103, but we will have to test it to be sure.

This change more closely mimics the setup we previously had with hyper_rustls, and allows Viceroy to be used even if only some root certificates could be loaded.
@aturon aturon mentioned this pull request Dec 14, 2021
cratelyn
cratelyn previously approved these changes Dec 14, 2021
Copy link
Contributor

@cratelyn cratelyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😻 thank you!!

lib/src/execute.rs Outdated Show resolved Hide resolved
@aturon
Copy link
Contributor Author

aturon commented Dec 14, 2021

Took your suggestions, re-✅?

Copy link
Contributor

@cratelyn cratelyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

♻️ ✔️ a pr so nice, i approved it twice ✌️

@aturon aturon merged commit 35a6881 into main Dec 14, 2021
@aturon aturon deleted the aturon/issue-103 branch December 14, 2021 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants