fix: Various fixes and updates #18
Conversation
- Use Connect API authentication - Simplify build finding using all_processing_builds - Update URL for build metadata in App Store Connect - Resolve errors created by changes in Spaceship
lib/watchbuild/runner.rb
Outdated
| build = nil | ||
| app.latest_version.candidate_builds.each do |b| | ||
| build = b if !build || b.upload_date > build.upload_date | ||
| end | ||
| build = app.all_processing_builds.sort_by(&:upload_date).last |
There was a problem hiding this comment.
I'm not entirely sure if this part works since I don't have a processing build in App Store Connect, so I tested it with build = app.builds.sort_by(&:upload_date).last instead
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
@googlebot I consent. |
There was a problem hiding this comment.
@rajivshah3 Thanks for making this PR! I added a few commits to remove the rest of the non Connect API usage to make things even more stable going forward 💪 Really appreciate this contribution ❤
all_processing_builds